This is an archive of the discontinued Mercurial Phabricator instance.

Differential D10457

nodemap: test various corruption scenario for the persistent nodemap
ClosedPublic

Authored by marmoute on Apr 16 2021, 12:08 PM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHG99aed233aa8d: nodemap: test various corruption scenario for the persistent nodemap
Summary

Corruption can happens in the wild, either because some of our code is buggy or
because repository were shared/transfered in a strange manners.

Currently one of the corruption case (not enough data) lead to a crash. We add
explicit tests for theses cases.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

marmoute created this revision.Apr 16 2021, 12:08 PM
pulkit accepted this revision.Apr 17 2021, 4:47 PM
This revision is now accepted and ready to land.Apr 17 2021, 4:47 PM

Revision Contents
Changeset List

PathPackages
Mtests/test-persistent-nodemap.t (57 lines)

Diff 27002

tests/test-persistent-nodemap.t

$ hg -R local-clone debugnodemap --metadata $ hg -R local-clone debugnodemap --metadata
uid: * (glob) uid: * (glob)
tip-rev: 5005 tip-rev: 5005
tip-node: 90d5d3ba2fc47db50f712570487cb261a68c8ffe tip-node: 90d5d3ba2fc47db50f712570487cb261a68c8ffe
data-length: 121088 data-length: 121088
data-unused: 0 data-unused: 0
data-unused: 0.000% data-unused: 0.000%
Test various corruption case
============================
Missing datafile
----------------
Test behavior with a missing datafile
$ hg clone --quiet --pull test-repo corruption-test-repo
$ ls -1 corruption-test-repo/.hg/store/00changelog*
corruption-test-repo/.hg/store/00changelog-*.nd (glob)
corruption-test-repo/.hg/store/00changelog.d
corruption-test-repo/.hg/store/00changelog.i
corruption-test-repo/.hg/store/00changelog.n
$ rm corruption-test-repo/.hg/store/00changelog*.nd
$ hg log -R corruption-test-repo -r .
changeset: 5005:90d5d3ba2fc4
tag: tip
user: test
date: Thu Jan 01 00:00:00 1970 +0000
summary: a2
$ ls -1 corruption-test-repo/.hg/store/00changelog*
corruption-test-repo/.hg/store/00changelog.d
corruption-test-repo/.hg/store/00changelog.i
corruption-test-repo/.hg/store/00changelog.n
Truncated data file
-------------------
Test behavior with a too short datafile
rebuild the missing data
$ hg -R corruption-test-repo debugupdatecache
$ ls -1 corruption-test-repo/.hg/store/00changelog*
corruption-test-repo/.hg/store/00changelog-*.nd (glob)
corruption-test-repo/.hg/store/00changelog.d
corruption-test-repo/.hg/store/00changelog.i
corruption-test-repo/.hg/store/00changelog.n
truncate the file
$ datafilepath=`ls corruption-test-repo/.hg/store/00changelog*.nd`
$ f -s $datafilepath
corruption-test-repo/.hg/store/00changelog-*.nd: size=121088 (glob)
$ dd if=$datafilepath bs=1000 count=10 of=$datafilepath-tmp status=none
$ mv $datafilepath-tmp $datafilepath
$ f -s $datafilepath
corruption-test-repo/.hg/store/00changelog-*.nd: size=10000 (glob)
Check that Mercurial reaction to this event
$ hg -R corruption-test-repo log -r .
abort: index 00changelog.i is corrupted
[50]
stream clone stream clone
------------ ------------
The persistent nodemap should exist after a streaming clone The persistent nodemap should exist after a streaming clone
$ hg clone -U --stream --config ui.ssh="\"$PYTHON\" \"$TESTDIR/dummyssh\"" ssh://user@dummy/test-repo stream-clone --debug | egrep '00(changelog|manifest)' $ hg clone -U --stream --config ui.ssh="\"$PYTHON\" \"$TESTDIR/dummyssh\"" ssh://user@dummy/test-repo stream-clone --debug | egrep '00(changelog|manifest)'
adding [s] 00manifest.n (70 bytes) adding [s] 00manifest.n (70 bytes)
adding [s] 00manifest.d (452 KB) (no-zstd !) adding [s] 00manifest.d (452 KB) (no-zstd !)