Page MenuHomePhabricator

nodemap: deal with data mmap error
ClosedPublic

Authored by marmoute on Fri, Apr 16, 12:08 PM.

Details

Summary

If the file is too small, the mmapread call would raise a ValueError. We catch
that and ignore nodemap content (as we do without mmap). This make the repository
slightly slower (until the next write) but usable. Unlike the current crash.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

marmoute created this revision.Fri, Apr 16, 12:08 PM
pulkit accepted this revision.Sat, Apr 17, 4:47 PM
This revision is now accepted and ready to land.Sat, Apr 17, 4:47 PM
This revision was automatically updated to reflect the committed changes.