This is an archive of the discontinued Mercurial Phabricator instance.

cmdutil: fix an uninitialize variable usage in clearunfinished()
ClosedPublic

Authored by mharbison72 on Apr 17 2021, 1:12 AM.

Details

Summary

I happened to notice that PyCharm flagged this while looking for something else.
I'm pretty sure it meant to check the current state in the iteration, and not
keep reusing the last one in the previous iteration.

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

mharbison72 created this revision.Apr 17 2021, 1:12 AM
marmoute accepted this revision.Apr 17 2021, 4:53 AM
marmoute added a subscriber: marmoute.

good spotting here…

pulkit accepted this revision.Apr 17 2021, 4:46 PM
This revision is now accepted and ready to land.Apr 17 2021, 4:46 PM