This is an archive of the discontinued Mercurial Phabricator instance.

Differential D10506

lint: fix failing code check
ClosedPublic

Authored by Alphare on Apr 21 2021, 11:59 AM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHGfceccc36873d: lint: fix failing code check
Summary

8d2b62d716b0 introduced code that test-check-code.t wasn't happy about, this
fixes it.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Alphare created this revision.Apr 21 2021, 11:59 AM
Alphare added a comment.Apr 21 2021, 12:01 PM

/!\ Meant for stable /!\

pulkit accepted this revision.Apr 28 2021, 6:37 AM
This revision is now accepted and ready to land.Apr 28 2021, 6:37 AM
Alphare added a commit: rHGfceccc36873d: lint: fix failing code check.Apr 28 2021, 11:09 AM
Closed by commit rHGfceccc36873d: lint: fix failing code check (authored by Alphare). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msetup.py (3 lines)

Diff 27191

setup.py

version = ( version = (
'%(latesttag)s+hg%(changessincelatesttag)s.%(node).12s' % kw '%(latesttag)s+hg%(changessincelatesttag)s.%(node).12s' % kw
) )
else: else:
version = '%(latesttag)s+hg%(latesttagdistance)s.%(node).12s' % kw version = '%(latesttag)s+hg%(latesttagdistance)s.%(node).12s' % kw
else: else:
version = '0+hg' + kw.get('node', '')[:12] version = '0+hg' + kw.get('node', '')[:12]
elif os.path.exists('mercurial/__version__.py'): elif os.path.exists('mercurial/__version__.py'):
data = open('mercurial/__version__.py').read() with open('mercurial/__version__.py') as f:
data = f.read()
version = re.search('version = b"(.*)"', data).group(1) version = re.search('version = b"(.*)"', data).group(1)
if version: if version:
versionb = version versionb = version
if not isinstance(versionb, bytes): if not isinstance(versionb, bytes):
versionb = versionb.encode('ascii') versionb = versionb.encode('ascii')
write_if_changed( write_if_changed(