( )⚙ D10526 git: pass the correct type to the sqlite3 query for baselog.hasnode()

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D10526

git: pass the correct type to the sqlite3 query for baselog.hasnode()
ClosedPublic

Authored by mharbison72 on Apr 27 2021, 7:53 PM.

Details

Reviewers
durin42
pulkit
Group Reviewers
hg-reviewers
Commits
rHGce24a00fe7f0: git: pass the correct type to the sqlite3 query for baselog.hasnode()
Summary

It looks like this function is mostly used in exchange (which isn't supported
now) and histedit (which crashes). But I did verify in a REPL that passing
bytes to db.execute() fails to find the row, whereas passing str works.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Revision Contents
Changeset List

PathPackages
Mhgext/git/gitlog.py (3 lines)

Diff 27434

hgext/git/gitlog.py

'SELECT node FROM changelog WHERE rev = ?', (r,) 'SELECT node FROM changelog WHERE rev = ?', (r,)
).fetchone() ).fetchone()
if t is None: if t is None:
raise error.LookupError(r, b'00changelog.i', _(b'no node')) raise error.LookupError(r, b'00changelog.i', _(b'no node'))
return bin(t[0]) return bin(t[0])
def hasnode(self, n): def hasnode(self, n):
t = self._db.execute( t = self._db.execute(
'SELECT node FROM changelog WHERE node = ?', (n,) 'SELECT node FROM changelog WHERE node = ?',
(pycompat.sysstr(n),),
).fetchone() ).fetchone()
return t is not None return t is not None
class baselogindex(object): class baselogindex(object):
def __init__(self, log): def __init__(self, log):
self._log = log self._log = log