This is an archive of the discontinued Mercurial Phabricator instance.

tests: synchronize the git and Mercurial username
ClosedPublic

Authored by mharbison72 on Apr 28 2021, 8:24 PM.

Details

Summary

The problem with the default name of "test" set by the test runner is the
stringutil methods are unable to split out separate user and email addresses
that git wants. This means the username is recorded in git as "test <test>".
Amending a commit with that user ends up trying to use "<test>" as the person
field for the new commit, and the git library complains about the angle
brackets. We should probably abort with a clearer message any time this bad
form is used with the git extension.

One of the commit dates is tweaked to recreate the ambiguous hash prefix from
before.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

mharbison72 created this revision.Apr 28 2021, 8:24 PM
pulkit accepted this revision.Apr 30 2021, 6:03 AM
This revision is now accepted and ready to land.Apr 30 2021, 6:03 AM
This revision was automatically updated to reflect the committed changes.