( )⚙ D1064 sampling: do not log less interesting "uiblocked" fields

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D1064

sampling: do not log less interesting "uiblocked" fields
ClosedPublic

Authored by quark on Oct 13 2017, 7:55 PM.
Tags
None
Subscribers
durham

Details

Reviewers
simonfar
durham
Group Reviewers
Restricted Project
Commits
rFBHGX9f00b0b32d46: sampling: do not log less interesting "uiblocked" fields
Summary

We got alias_*_blocked and unknown_system_* logged which bloated the
table. Since we are not using them, let's just remove them from logging.

Diff Detail

Repository
rFBHGX Facebook Mercurial Extensions
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

quark created this revision.Oct 13 2017, 7:55 PM
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 13 2017, 7:55 PM
quark updated this revision to Diff 2704.Oct 13 2017, 7:58 PM
durham accepted this revision.Oct 31 2017, 12:23 PM
durham added a subscriber: durham.

Where are these coming from?

This revision is now accepted and ready to land.Oct 31 2017, 12:23 PM
quark added a comment.Nov 1 2017, 2:31 PM
In D1064#21095, @durham wrote:

Where are these coming from?

quark % rg _blockedtimes
ui.py
246:            self._blockedtimes = src._blockedtimes
259:            self._blockedtimes = collections.defaultdict(int)
329:            self._blockedtimes[key + '_blocked'] += \ # <<<<<<< key could be "alias_xxx" or "system_xxx"
909:            self._blockedtimes['stdio_blocked'] += \
958:            self._blockedtimes['stdio_blocked'] += \

dispatch.py
198:            req.ui._blockedtimes['command_duration'] = duration * 1000
199:            req.ui.log('uiblocked', 'ui blocked ms', **req.ui._blockedtimes) # <<<<<<< This sends unwanted items
Closed by commit rFBHGX9f00b0b32d46: sampling: do not log less interesting "uiblocked" fields (authored by quark). · Explain WhyNov 2 2017, 3:04 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mhgext3rd/sampling.py (8 lines)

Diff 2704

hgext3rd/sampling.py

"msg":"", "msg":"",
"opts":{"t":42}}\0 "opts":{"t":42}}\0
""" """
if not util.safehasattr(self, 'samplingfilters'): if not util.safehasattr(self, 'samplingfilters'):
self.samplingfilters = logtofile.computesamplingfilters(self) self.samplingfilters = logtofile.computesamplingfilters(self)
if event not in self.samplingfilters: if event not in self.samplingfilters:
return super(logtofile, self).log(event, *msg, **opts) return super(logtofile, self).log(event, *msg, **opts)
# special case: remove less interesting blocked fields starting
# with "unknown_" or "alias_".
if event == 'uiblocked':
opts = {k: v
for k, v in opts.items()
if (not k.startswith('alias_') and not
k.startswith('unknown_'))}
ref = self.samplingfilters[event] ref = self.samplingfilters[event]
script = _getcandidatelocation(ui) script = _getcandidatelocation(ui)
if script: if script:
try: try:
opts["metrics_type"] = event opts["metrics_type"] = event
if msg: if msg:
# ui.log treats msg as a format string + format args. # ui.log treats msg as a format string + format args.
opts["msg"] = msg[0] % msg[1:] opts["msg"] = msg[0] % msg[1:]