This is an archive of the discontinued Mercurial Phabricator instance.

Differential D10727

updatecaches: introduce a set of constants to control which are updated
ClosedPublic

Authored by marmoute on May 18 2021, 3:47 AM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHGd1589957fdcb: updatecaches: introduce a set of constants to control which are updated
Summary

Passing around a set of constant to select what need warming will be cleaner
and more flexible. We did not changed the API yet, as this changes is already
large enough. In the rest of the rest we will change more code to actually use
this constants (or more realistically pre-defined set of constant directly)

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Revision Contents
Changeset List

Diff 28147

mercurial/interfaces/repository.py

# repository.py - Interfaces and base classes for repositories and peers. # repository.py - Interfaces and base classes for repositories and peers.
# coding: utf-8
# #
# Copyright 2017 Gregory Szorc <gregory.szorc@gmail.com> # Copyright 2017 Gregory Szorc <gregory.szorc@gmail.com>
# #
# This software may be used and distributed according to the terms of the # This software may be used and distributed according to the terms of the
# GNU General Public License version 2 or any later version. # GNU General Public License version 2 or any later version.
from __future__ import absolute_import from __future__ import absolute_import
) )
CG_DELTAMODE_STD = b'default' CG_DELTAMODE_STD = b'default'
CG_DELTAMODE_PREV = b'previous' CG_DELTAMODE_PREV = b'previous'
CG_DELTAMODE_FULL = b'fulltext' CG_DELTAMODE_FULL = b'fulltext'
CG_DELTAMODE_P1 = b'p1' CG_DELTAMODE_P1 = b'p1'
## Cache related constants:
#
# Used to control which cache should be warmed in a repo.updatecaches(…) call.
# Warm branchmaps of all known repoview's filter-level
CACHE_BRANCHMAP_ALL = b"branchmap-all"
# Warm branchmaps of repoview's filter-level used by server
CACHE_BRANCHMAP_SERVED = b"branchmap-served"
# Warm internal changelog cache (eg: persistent nodemap)
CACHE_CHANGELOG_CACHE = b"changelog-cache"
# Warm full manifest cache
CACHE_FULL_MANIFEST = b"full-manifest"
# Warm file-node-tags cache
CACHE_FILE_NODE_TAGS = b"file-node-tags"
# Warm internal manifestlog cache (eg: persistent nodemap)
CACHE_MANIFESTLOG_CACHE = b"manifestlog-cache"
# Warn rev branch cache
CACHE_REV_BRANCH = b"rev-branch-cache"
# Warm tags' cache for default repoview'
CACHE_TAGS_DEFAULT = b"tags-default"
# Warm tags' cache for repoview's filter-level used by server
CACHE_TAGS_SERVED = b"tags-served"
# the cache to warm by default after a simple transaction
# (this is a mutable set to let extension update it)
CACHES_DEFAULT = {
CACHE_BRANCHMAP_SERVED,
}
# the caches to warm when warming all of them
# (this is a mutable set to let extension update it)
CACHES_ALL = {
CACHE_BRANCHMAP_SERVED,
CACHE_BRANCHMAP_ALL,
CACHE_CHANGELOG_CACHE,
CACHE_FILE_NODE_TAGS,
CACHE_FULL_MANIFEST,
CACHE_MANIFESTLOG_CACHE,
CACHE_TAGS_DEFAULT,
CACHE_TAGS_SERVED,
}
class ipeerconnection(interfaceutil.Interface): class ipeerconnection(interfaceutil.Interface):
"""Represents a "connection" to a repository. """Represents a "connection" to a repository.
This is the base interface for representing a connection to a repository. This is the base interface for representing a connection to a repository.
It holds basic properties and methods applicable to all peer types. It holds basic properties and methods applicable to all peer types.
This is not a complete interface definition and should not be used This is not a complete interface definition and should not be used
outside of this module. outside of this module.

mercurial/localrepo.py

be skipped, namely the `.fnodetags` one. This argument is 5.8 specific be skipped, namely the `.fnodetags` one. This argument is 5.8 specific
as we plan for a cleaner way to deal with this for 5.9. as we plan for a cleaner way to deal with this for 5.9.
""" """
if tr is not None and tr.hookargs.get(b'source') == b'strip': if tr is not None and tr.hookargs.get(b'source') == b'strip':
# During strip, many caches are invalid but # During strip, many caches are invalid but
# later call to `destroyed` will refresh them. # later call to `destroyed` will refresh them.
return return
unfi = self.unfiltered()
if full:
caches = repository.CACHES_ALL
if full == b"post-clone":
caches = caches.copy()
caches.discard(repository.CACHE_FILE_NODE_TAGS)
else:
caches = repository.CACHES_DEFAULT
if repository.CACHE_BRANCHMAP_SERVED in caches:
if tr is None or tr.changes[b'origrepolen'] < len(self): if tr is None or tr.changes[b'origrepolen'] < len(self):
# accessing the 'served' branchmap should refresh all the others, # accessing the 'served' branchmap should refresh all the others,
self.ui.debug(b'updating the branch cache\n') self.ui.debug(b'updating the branch cache\n')
self.filtered(b'served').branchmap() self.filtered(b'served').branchmap()
self.filtered(b'served.hidden').branchmap() self.filtered(b'served.hidden').branchmap()
if full: if repository.CACHE_CHANGELOG_CACHE in caches:
unfi = self.unfiltered()
self.changelog.update_caches(transaction=tr) self.changelog.update_caches(transaction=tr)
if repository.CACHE_MANIFESTLOG_CACHE in caches:
self.manifestlog.update_caches(transaction=tr) self.manifestlog.update_caches(transaction=tr)
if repository.CACHE_REV_BRANCH in caches:
rbc = unfi.revbranchcache() rbc = unfi.revbranchcache()
for r in unfi.changelog: for r in unfi.changelog:
rbc.branchinfo(r) rbc.branchinfo(r)
rbc.write() rbc.write()
if repository.CACHE_FULL_MANIFEST in caches:
# ensure the working copy parents are in the manifestfulltextcache # ensure the working copy parents are in the manifestfulltextcache
for ctx in self[b'.'].parents(): for ctx in self[b'.'].parents():
ctx.manifest() # accessing the manifest is enough ctx.manifest() # accessing the manifest is enough
if not full == b"post-clone": if repository.CACHE_FILE_NODE_TAGS in caches:
# accessing fnode cache warms the cache # accessing fnode cache warms the cache
tagsmod.fnoderevs(self.ui, unfi, unfi.changelog.revs()) tagsmod.fnoderevs(self.ui, unfi, unfi.changelog.revs())
if repository.CACHE_TAGS_DEFAULT in caches:
# accessing tags warm the cache # accessing tags warm the cache
self.tags() self.tags()
if repository.CACHE_TAGS_SERVED in caches:
self.filtered(b'served').tags() self.filtered(b'served').tags()
# The `full` arg is documented as updating even the lazily-loaded if repository.CACHE_BRANCHMAP_ALL in caches:
# caches immediately, so we're forcing a write to cause these caches # The CACHE_BRANCHMAP_ALL updates lazily-loaded caches immediately,
# to be warmed up even if they haven't explicitly been requested # so we're forcing a write to cause these caches to be warmed up
# yet (if they've never been used by hg, they won't ever have been # even if they haven't explicitly been requested yet (if they've
# written, even if they're a subset of another kind of cache that # never been used by hg, they won't ever have been written, even if
# *has* been used). # they're a subset of another kind of cache that *has* been used).
for filt in repoview.filtertable.keys(): for filt in repoview.filtertable.keys():
filtered = self.filtered(filt) filtered = self.filtered(filt)
filtered.branchmap().write(filtered) filtered.branchmap().write(filtered)
def invalidatecaches(self): def invalidatecaches(self):
if '_tagscache' in vars(self): if '_tagscache' in vars(self):
# can't use delattr on proxy # can't use delattr on proxy