This is an archive of the discontinued Mercurial Phabricator instance.

Differential D10731

updatecaches: deprecate the `full` argument
ClosedPublic

Authored by marmoute on May 18 2021, 3:48 AM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHG8b2d09c7e5cd: updatecaches: deprecate the `full` argument
Summary

Now that all users were migrated, we can use deprecate the old way. This would
give potential extensions code a heads up on the API change.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

marmoute created this revision.May 18 2021, 3:48 AM
pulkit accepted this revision.May 20 2021, 4:47 AM
This revision is now accepted and ready to land.May 20 2021, 4:47 AM
marmoute added a commit: rHG8b2d09c7e5cd: updatecaches: deprecate the `full` argument.May 20 2021, 9:22 AM
Closed by commit rHG8b2d09c7e5cd: updatecaches: deprecate the `full` argument (authored by marmoute). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/localrepo.py (19 lines)

Diff 28151

mercurial/localrepo.py

""" """
if tr is not None and tr.hookargs.get(b'source') == b'strip': if tr is not None and tr.hookargs.get(b'source') == b'strip':
# During strip, many caches are invalid but # During strip, many caches are invalid but
# later call to `destroyed` will refresh them. # later call to `destroyed` will refresh them.
return return
unfi = self.unfiltered() unfi = self.unfiltered()
if caches is None:
if full: if full:
msg = (
"`full` argument for `repo.updatecaches` is deprecated\n"
"(use `caches=repository.CACHE_ALL` instead)"
)
self.ui.deprecwarn(msg, "5.9")
caches = repository.CACHES_ALL caches = repository.CACHES_ALL
if full == b"post-clone": if full == b"post-clone":
caches = repository.CACHES_POST_CLONE caches = repository.CACHES_POST_CLONE
else: caches = repository.CACHES_ALL
elif caches is None:
caches = repository.CACHES_DEFAULT caches = repository.CACHES_DEFAULT
if repository.CACHE_BRANCHMAP_SERVED in caches: if repository.CACHE_BRANCHMAP_SERVED in caches:
if tr is None or tr.changes[b'origrepolen'] < len(self): if tr is None or tr.changes[b'origrepolen'] < len(self):
# accessing the 'served' branchmap should refresh all the others, # accessing the 'served' branchmap should refresh all the others,
self.ui.debug(b'updating the branch cache\n') self.ui.debug(b'updating the branch cache\n')
self.filtered(b'served').branchmap() self.filtered(b'served').branchmap()
self.filtered(b'served.hidden').branchmap() self.filtered(b'served.hidden').branchmap()