Page MenuHomePhabricator

errors: make StorageError subclass Error, attaching an exit code to it
ClosedPublic

Authored by martinvonz on May 19 2021, 1:47 AM.

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

martinvonz created this revision.May 19 2021, 1:47 AM
pulkit accepted this revision.May 20 2021, 4:45 AM
This revision is now accepted and ready to land.May 20 2021, 4:45 AM

This triggered an issue with the Rust version of the index (which broke our CI), I have send a fix for it as D10764

This triggered an issue with the Rust version of the index (which broke our CI), I have send a fix for it as D10764

I'll queue that patch, thanks. Could I have noticed that myself? I suppose it'll be too slow for all contributors to always run tests with and without rust (and py2, and pure), so it's fine to notice this in CI.

Thanks! I always use the CI before queuing patches. It's kind of cumbersome, but it's the only real solution.

Thanks! I always use the CI before queuing patches. It's kind of cumbersome, but it's the only real solution.

It seems like it would be nice if CI could run on all pending patches and comment on them whether tests pass or fail. Any idea how hard that would be to set up?