This is an archive of the discontinued Mercurial Phabricator instance.

dirstate-tree: Downgrade `&mut Node` to `&Node` in status and serialization
ClosedPublic

Authored by SimonSapin on May 19 2021, 12:36 PM.

Details

Summary

Mutable access is not used, and upcoming changes will make it more costly
(with copy-on-write nodes that can be read from disk representation)

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

SimonSapin created this revision.May 19 2021, 12:36 PM
Alphare added inline comments.
rust/hg-core/src/dirstate_tree/status.rs
284

Shouldn't this be par_iter()?

baymax updated this revision to Diff 28169.May 21 2021, 4:37 AM

✅ refresh by Heptapod after a successful CI run (🐙 💚)

baymax updated this revision to Diff 28268.May 30 2021, 3:27 PM

✅ refresh by Heptapod after a successful CI run (🐙 💚)

Alphare accepted this revision.May 31 2021, 3:39 AM
This revision is now accepted and ready to land.May 31 2021, 3:39 AM