This is an archive of the discontinued Mercurial Phabricator instance.

dirstate-tree: Add `NodeRef` and `ChildNodesRef` enums
ClosedPublic

Authored by SimonSapin on May 19 2021, 12:37 PM.

Details

Summary

They are used instead of &Node and &ChildNodes respectively.
The ChildNodes type alias also becomes a similar enum.

For now they only have one variant each, to be extended later.
Adding enums now forces various use sites go through new methods
instead of manipulating the underlying data structure directly.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

SimonSapin created this revision.May 19 2021, 12:37 PM
Alphare accepted this revision.May 21 2021, 3:55 AM
This revision is now accepted and ready to land.May 21 2021, 3:55 AM
baymax updated this revision to Diff 28171.May 21 2021, 4:37 AM

✅ refresh by Heptapod after a successful CI run (🐙 💚)

baymax updated this revision to Diff 28270.May 30 2021, 3:27 PM

✅ refresh by Heptapod after a successful CI run (🐙 💚)