This is an archive of the discontinued Mercurial Phabricator instance.

Differential D10763

tests: partially fix test-transaction-rollback-on-revlog-split.t on Windows
ClosedPublic

Authored by mharbison72 on May 21 2021, 12:37 AM.

Details

Reviewers
valentin.gatienbaron
pulkit
Group Reviewers
hg-reviewers
Commits
rHG93fc0a13b7e8: tests: partially fix test-transaction-rollback-on-revlog-split.t on Windows
Summary

For whatever reason, the extra space causes different output on Windows:

$ printf '% 20d' '1' | xxd -
0000000: 2020 2020 2020 2020 2020 2020 2020 2020
0000010: 2020 2020 31                                 1

vs WSL:

/mnt/c/Users/Matt/hg/tests$ printf '% 20d' '1' | xxd -
00000000: 2020 2020 2020 2020 2020 2020 2020 2020
00000010: 2020 2031

Without the space, they both agree the last word is 2031. There are other
failures on Windows that I don't understand that are introduced by 46b828b85eb7
and 18415fc918a1.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

mharbison72 created this revision.May 21 2021, 12:37 AM
valentin.gatienbaron accepted this revision.May 21 2021, 8:12 AM
valentin.gatienbaron added a subscriber: valentin.gatienbaron.

Maybe the forward slashes in the extension created at the beginning of the test is the source of the other windows failures?

pulkit accepted this revision.May 23 2021, 4:03 PM
This revision is now accepted and ready to land.May 23 2021, 4:03 PM

Revision Contents
Changeset List

Diff 28191

tests/test-transaction-rollback-on-revlog-split.t

after the index has been replaced. after the index has been replaced.
Test repo has one small, one moderate and one big change. The clone has Test repo has one small, one moderate and one big change. The clone has
the small and moderate change and will transition to non-inline storage when the small and moderate change and will transition to non-inline storage when
adding the big change. adding the big change.
$ hg init troffset-computation --config format.revlog-compression=none $ hg init troffset-computation --config format.revlog-compression=none
$ cd troffset-computation $ cd troffset-computation
$ printf '% 20d' '1' > file $ printf '%20d' '1' > file
$ hg commit -Aqm_ $ hg commit -Aqm_
$ printf '% 1024d' '1' > file $ printf '%1024d' '1' > file
$ hg commit -Aqm_ $ hg commit -Aqm_
$ dd if=/dev/zero of=file bs=1k count=128 > /dev/null 2>&1 $ dd if=/dev/zero of=file bs=1k count=128 > /dev/null 2>&1
$ hg commit -Aqm_ $ hg commit -Aqm_
$ cd .. $ cd ..
$ hg clone -r 1 troffset-computation troffset-computation-copy --config format.revlog-compression=none -q $ hg clone -r 1 troffset-computation troffset-computation-copy --config format.revlog-compression=none -q
$ cd troffset-computation-copy $ cd troffset-computation-copy