Page MenuHomePhabricator

tests: partially fix test-transaction-rollback-on-revlog-split.t on Windows
ClosedPublic

Authored by mharbison72 on May 21 2021, 12:37 AM.

Details

Summary

For whatever reason, the extra space causes different output on Windows:

$ printf '% 20d' '1' | xxd -
0000000: 2020 2020 2020 2020 2020 2020 2020 2020
0000010: 2020 2020 31                                 1

vs WSL:

/mnt/c/Users/Matt/hg/tests$ printf '% 20d' '1' | xxd -
00000000: 2020 2020 2020 2020 2020 2020 2020 2020
00000010: 2020 2031

Without the space, they both agree the last word is 2031. There are other
failures on Windows that I don't understand that are introduced by 46b828b85eb7
and 18415fc918a1.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

mharbison72 created this revision.May 21 2021, 12:37 AM

Maybe the forward slashes in the extension created at the beginning of the test is the source of the other windows failures?

pulkit accepted this revision.May 23 2021, 4:03 PM
This revision is now accepted and ready to land.May 23 2021, 4:03 PM