This is an archive of the discontinued Mercurial Phabricator instance.

Differential D1081

tests: add check in test-check-commit.t to verify releasenotes directives
AbandonedPublic

Authored by durin42 on Oct 14 2017, 4:41 PM.

Details

Reviewers
indygreg
yuja
pulkit
Group Reviewers
hg-reviewers
Summary

I had some trouble getting this right in a recent change of mine, and
also found that some of our commits since 4.3 don't work right, so
let's bounce commits that get it wrong.

Test Plan

made a commit with broken releasenotes directives, verified I
got some failure output from test-check-commit.t. It's not the
prettiest, but it'll do for now.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

durin42 created this revision.Oct 14 2017, 4:41 PM
indygreg accepted this revision.Oct 14 2017, 5:00 PM
This revision is now accepted and ready to land.Oct 14 2017, 5:00 PM
yuja requested changes to this revision.Oct 14 2017, 11:48 PM
yuja added a subscriber: yuja.

It makes a file named "notes" in the repository because of cd $TESTDIR/...
Perhaps we should send the output to > /dev/null.

This revision now requires changes to proceed.Oct 14 2017, 11:48 PM
durin42 updated this revision to Diff 2762.Oct 15 2017, 12:44 AM
durin42 added a comment.Oct 15 2017, 12:45 AM
In D1081#18135, @yuja wrote:

It makes a file named "notes" in the repository because of cd $TESTDIR/...
Perhaps we should send the output to > /dev/null.

D'oh. Fixed in the revised version.

yuja requested changes to this revision.Oct 15 2017, 9:02 AM

Looked good, but it appears that releasenotes requires fuzzywuzzy.

+  abort: No module named fuzzywuzzy.fuzz!

(on gcc112)

Another problem is it doubles the execution time of test-check-commit.t
and timed out on my laptop. Perhaps, we can move hg releasenotes out
of the shell for-loop.

This revision now requires changes to proceed.Oct 15 2017, 9:02 AM
pulkit requested changes to this revision.Oct 17 2017, 7:24 PM
pulkit added a subscriber: pulkit.

I have tweaked releasenotes to not error out in this case, rather show a warning only. So this patch is no longer applicable.

durin42 abandoned this revision.Feb 21 2018, 10:19 PM

Revision Contents
Changeset List

PathPackages
Mtests/test-check-commit.t (5 lines)

Diff 2762

tests/test-check-commit.t

> testrepohg export --git $node \ > testrepohg export --git $node \
> | contrib/check-commit > ${TESTTMP}/check-commit.out > | contrib/check-commit > ${TESTTMP}/check-commit.out
> if [ $? -ne 0 ]; then > if [ $? -ne 0 ]; then
> echo "Revision $node does not comply with rules" > echo "Revision $node does not comply with rules"
> echo '------------------------------------------------------' > echo '------------------------------------------------------'
> cat ${TESTTMP}/check-commit.out > cat ${TESTTMP}/check-commit.out
> echo > echo
> fi > fi
> testrepohg --config extensions.releasenotes= releasenotes -r $node \
> "${TESTTMP}/notes"
> if [ $? -ne 0 ] ; then
> echo "Revision $node has broken releasenotes declaration"
> fi
> done > done