Page MenuHomePhabricator

cmdutil: make checknotesize() work on str-keyed opts
AcceptedPublic

Authored by martinvonz on Thu, Jun 10, 7:21 PM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Summary

Since this patch changes the behavior of the function, I consider it a
bonus if the signature also changes so that extensions can detect
which version they're dealing with (for the record, I don't have any
such extensions). Therefore, I also dropped an unused ui argument
and renamed the function to use snake_case.

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

martinvonz created this revision.Thu, Jun 10, 7:21 PM
pulkit accepted this revision.Mon, Jun 14, 4:34 PM
This revision is now accepted and ready to land.Mon, Jun 14, 4:34 PM