Page MenuHomePhabricator

histedit: don't swallow errors that happen when updating the working copy
ClosedPublic

Authored by martinvonz on Jun 18 2021, 5:56 PM.

Details

Summary

Commit 34165875fa5d (histedit: limit updated and merging output to
important updates, 2016-02-03) added a call to
ui.pushbuffer(labeled=True, errors=True). I don't know if there was
a reason for the errors=True (nor the labeled=True bit, which I
removed in the previous commit). It seems bad to just discard the
errors, so let's not do that. By not doing that, we can also remove a
workaround for the lack of errors from test-removeemptydirs.t.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.