This is an archive of the discontinued Mercurial Phabricator instance.

Differential D10870

typing: disable warnings for a couple of Windows specific attributes
ClosedPublic

Authored by mharbison72 on Jun 11 2021, 11:45 PM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHGf77404040776: typing: disable warnings for a couple of Windows specific attributes

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

mharbison72 created this revision.Jun 11 2021, 11:45 PM
pulkit accepted this revision.Jun 14 2021, 4:31 PM
This revision is now accepted and ready to land.Jun 14 2021, 4:31 PM
mharbison72 added a comment.Jun 21 2021, 11:13 PM

Can this get grafted to stable? It goes with 5b3513177f2b. I'm not sure why the stable branch wasn't flagged in phab, because that's where the obsolete commit is in my repo.

Alphare added a subscriber: Alphare.Jun 22 2021, 4:02 AM
In D10870#166641, @mharbison72 wrote:

Can this get grafted to stable? It goes with 5b3513177f2b. I'm not sure why the stable branch wasn't flagged in phab, because that's where the obsolete commit is in my repo.

The weird thing is that phab knows it's supposed to be on stable since the notification mail for this diff's creation contains the information.

Revision Contents
Changeset List

PathPackages
Mmercurial/windows.py (6 lines)

Diff 28596

mercurial/windows.py

def get_password(): def get_password():
"""Prompt for password with echo off, using Windows getch(). """Prompt for password with echo off, using Windows getch().
This shouldn't be called directly- use ``ui.getpass()`` instead, which This shouldn't be called directly- use ``ui.getpass()`` instead, which
checks if the session is interactive first. checks if the session is interactive first.
""" """
pw = "" pw = ""
while True: while True:
c = msvcrt.getwch() c = msvcrt.getwch() # pytype: disable=module-attr
if c == '\r' or c == '\n': if c == '\r' or c == '\n':
break break
if c == '\003': if c == '\003':
raise KeyboardInterrupt raise KeyboardInterrupt
if c == '\b': if c == '\b':
pw = pw[:-1] pw = pw[:-1]
else: else:
pw = pw + c pw = pw + c
msvcrt.putwch('\r') msvcrt.putwch('\r') # pytype: disable=module-attr
msvcrt.putwch('\n') msvcrt.putwch('\n') # pytype: disable=module-attr
return encoding.strtolocal(pw) return encoding.strtolocal(pw)
class winstdout(object): class winstdout(object):
"""Some files on Windows misbehave. """Some files on Windows misbehave.
When writing to a broken pipe, EINVAL instead of EPIPE may be raised. When writing to a broken pipe, EINVAL instead of EPIPE may be raised.