( )⚙ D10914 upgrade_utils: fix crash for removecldeltachain action

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D10914

upgrade_utils: fix crash for removecldeltachain action
ClosedPublic

Authored by Mathiasdm on Jun 28 2021, 6:14 AM.

Details

Reviewers
marmoute
Group Reviewers
hg-reviewers
Commits
rHG4259a72fe528: upgrade_utils: fix crash for removecldeltachain action
Summary

This fixes issue6383.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Mathiasdm created this revision.Jun 28 2021, 6:14 AM
marmoute accepted this revision.EditedJun 28 2021, 6:22 AM
marmoute added a subscriber: marmoute.

This sounds reasonable for stable.

Maybe this should not longer be private, optional, attribute then ? (for default)

Mathias De Mare <mathias.de_mare@nokia.com> added a commit: rHG4259a72fe528: upgrade_utils: fix crash for removecldeltachain action.Jul 19 2021, 9:15 AM
This revision was not accepted when it landed; it landed in state Needs Review.
Closed by commit rHG4259a72fe528: upgrade_utils: fix crash for removecldeltachain action (authored by Mathias De Mare <mathias.de_mare@nokia.com>). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/upgrade_utils/actions.py (5 lines)

Diff 29428

mercurial/upgrade_utils/actions.py

recommended optimizations from the improvements list that make sense, recommended optimizations from the improvements list that make sense,
etc. etc.
Returns a list of action names. Returns a list of action names.
""" """
newactions = [] newactions = []
for d in format_upgrades: for d in format_upgrades:
if util.safehasattr(d, '_requirement'):
name = d._requirement name = d._requirement
else:
name = None
# If the action is a requirement that doesn't show up in the # If the action is a requirement that doesn't show up in the
# destination requirements, prune the action. # destination requirements, prune the action.
if name is not None and name not in destreqs: if name is not None and name not in destreqs:
continue continue
newactions.append(d) newactions.append(d)