This is an archive of the discontinued Mercurial Phabricator instance.

check-code: stop forbidding return code result

Authored by marmoute on Jul 6 2021, 7:13 AM.



There is no explication of what is the intend of that check and what is the

I suspect this comes from the transition to the "unified test" format circa

  1. With the non zero return explicitly listed in the output explicit $?

checking became Redundant. However there is valid use case for checking $? so I
am dropping this check.

Diff Detail

rHG Mercurial
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

marmoute created this revision.Jul 6 2021, 7:13 AM
Alphare accepted this revision.Jul 6 2021, 9:50 AM
This revision is now accepted and ready to land.Jul 6 2021, 9:50 AM
baymax updated this revision to Diff 28827.Jul 6 2021, 10:14 AM

✅ refresh by Heptapod after a successful CI run (🐙 💚)

This revision was automatically updated to reflect the committed changes.