( )⚙ D10994 check-code: stop forbidding return code result

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D10994

check-code: stop forbidding return code result
ClosedPublic

Authored by marmoute on Jul 6 2021, 7:13 AM.

Details

Reviewers
Alphare
Group Reviewers
hg-reviewers
Commits
rHG9b1710c50230: check-code: stop forbidding return code result
Summary

There is no explication of what is the intend of that check and what is the
alternative.

I suspect this comes from the transition to the "unified test" format circa

  1. With the non zero return explicitly listed in the output explicit $?

checking became Redundant. However there is valid use case for checking $? so I
am dropping this check.

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

marmoute created this revision.Jul 6 2021, 7:13 AM
Alphare accepted this revision.Jul 6 2021, 9:50 AM
This revision is now accepted and ready to land.Jul 6 2021, 9:50 AM
baymax updated this revision to Diff 28827.Jul 6 2021, 10:14 AM

✅ refresh by Heptapod after a successful CI run (🐙 💚)

marmoute added a commit: rHG9b1710c50230: check-code: stop forbidding return code result.Jul 6 2021, 10:35 AM
Closed by commit rHG9b1710c50230: check-code: stop forbidding return code result (authored by marmoute). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mcontrib/check-code.py (1 line)

Diff 28818

contrib/check-code.py

utestpats = [ utestpats = [
[ [
(r'^(\S.*|| [$>] \S.*)[ \t]\n', "trailing whitespace on non-output"), (r'^(\S.*|| [$>] \S.*)[ \t]\n', "trailing whitespace on non-output"),
( (
uprefix + r'.*\|\s*sed[^|>\n]*\n', uprefix + r'.*\|\s*sed[^|>\n]*\n',
"use regex test output patterns instead of sed", "use regex test output patterns instead of sed",
), ),
(uprefix + r'(true|exit 0)', "explicit zero exit unnecessary"), (uprefix + r'(true|exit 0)', "explicit zero exit unnecessary"),
(uprefix + r'.*(?<!\[)\$\?', "explicit exit code checks unnecessary"),
( (
uprefix + r'.*\|\| echo.*(fail|error)', uprefix + r'.*\|\| echo.*(fail|error)',
"explicit exit code checks unnecessary", "explicit exit code checks unnecessary",
), ),
(uprefix + r'set -e', "don't use set -e"), (uprefix + r'set -e', "don't use set -e"),
(uprefix + r'(\s|fi\b|done\b)', "use > for continued lines"), (uprefix + r'(\s|fi\b|done\b)', "use > for continued lines"),
( (
uprefix + r'.*:\.\S*/', uprefix + r'.*:\.\S*/',