Page MenuHomePhabricator

amend: make `hg amend -r` fold temporary commit into target commit
Needs ReviewPublic

Authored by martinvonz on Jul 9 2021, 4:28 PM.

Details

Reviewers
Alphare
Group Reviewers
hg-reviewers

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

martinvonz created this revision.Jul 9 2021, 4:28 PM
Alphare accepted this revision as: Alphare.Jul 12 2021, 5:23 AM
martinvonz updated this revision to Diff 29212.Jul 12 2021, 2:43 PM

Not much feedback here but for the previous one of "why are we going through the full trouble of doing cross extensions delegation instead of using rewriteutil function instead?

hgext/amend.py
265–269

This would probably win to be prepared outside of the call to help readability.

(also, this seems weird and increase my questioning about why we are using rebase directly instead of a more appropriate API).

270–272

This would probably win to be prepared outside of the call to help readability.

(also, this seems weird and increase my questioning about why we are using rebase directly instead of a more appropriate API).

277–278

Is there any cases where this could effectively fails ?

martinvonz updated this revision to Diff 29295.Jul 15 2021, 8:35 PM