… instead of appending to the existing one. This is based on keeping track
of how much of the existing data is not used anymore.
Details
- Reviewers
marmoute - Group Reviewers
hg-reviewers - Commits
- rHGd94118365ec5: dirstate-v2: Add heuristic for when to create a new data file
Diff Detail
- Repository
- rHG Mercurial
- Branch
- default
- Lint
No Linters Available - Unit
No Unit Test Coverage
Event Timeline
rust/hg-core/src/dirstate_tree/dirstate_map.rs | ||
---|---|---|
52–53 | Maybe point out in the commentthat this is an estimate, not an exact value ? | |
131 | We should document this, (and point out this is an estimate) | |
488 | We should put this ratio in some constant (at least) to make its value clearer and easier to configure. | |
rust/hg-core/src/dirstate_tree/on_disk.rs | ||
76 | same feedback about being clear this is an estimate. |
At the moment I *think* unreachable_bytes should be exact. This might change if we change the serializer to reuse paths in more than one node each (within the same "version" of the tree): then when removing a node we wouldn’t know if that path is still reachable from somewhere else. (Unless we add some kind of reference-counting for paths, but I think it’s not worth it.)
Probably let's just say that it might become an estimate later and that it's not that important anyway. The change looks good to me otherwise