Page MenuHomePhabricator

upgrade: byteify an i18n message
ClosedPublic

Authored by mharbison72 on Jul 21 2021, 4:07 PM.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

mharbison72 created this revision.Jul 21 2021, 4:07 PM
marmoute requested changes to this revision.EditedJul 21 2021, 4:56 PM
marmoute added a subscriber: marmoute.

__file__ is not bytes, so this will crash, will it not ?

This revision now requires changes to proceed.Jul 21 2021, 4:56 PM

file is not bytes, so this will crash, will it not ?

I don't follow. _() wants bytes, and the path variable that is formatted in the string is also bytes (because it is split with bytes).

marmoute accepted this revision.Jul 21 2021, 6:01 PM

Ha, I confused this with something else. Sorry about that.

This revision now requires review to proceed.Jul 21 2021, 6:01 PM
Alphare accepted this revision.Jul 22 2021, 12:01 PM
This revision is now accepted and ready to land.Jul 22 2021, 12:01 PM
This revision was automatically updated to reflect the committed changes.