( )⚙ D1120 releasenotes: move import of fuzzywuzzy to import level

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D1120

releasenotes: move import of fuzzywuzzy to import level
ClosedPublic

Authored by pulkit on Oct 16 2017, 2:28 PM.

Details

Reviewers
yuja
Group Reviewers
hg-reviewers
Commits
rHGbc2caa4b4480: releasenotes: move import of fuzzywuzzy to import level
Summary

This will help us in determining easily that whether fuzzywuzzy is loaded or not
loaded in any of the function.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

pulkit created this revision.Oct 16 2017, 2:28 PM
yuja accepted this revision.Oct 17 2017, 9:44 AM
This revision is now accepted and ready to land.Oct 17 2017, 9:44 AM
Closed by commit rHGbc2caa4b4480: releasenotes: move import of fuzzywuzzy to import level (authored by pulkit). · Explain WhyOct 17 2017, 10:16 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mhgext/releasenotes.py (12 lines)

Diff 2831

hgext/releasenotes.py

registrar, registrar,
scmutil, scmutil,
util, util,
) )
cmdtable = {} cmdtable = {}
command = registrar.command(cmdtable) command = registrar.command(cmdtable)
try:
import fuzzywuzzy.fuzz as fuzz
fuzz.token_set_ratio
except ImportError:
fuzz = None
# Note for extension authors: ONLY specify testedwith = 'ships-with-hg-core' for # Note for extension authors: ONLY specify testedwith = 'ships-with-hg-core' for
# extensions which SHIP WITH MERCURIAL. Non-mainline extensions should # extensions which SHIP WITH MERCURIAL. Non-mainline extensions should
# be specifying the version(s) of Mercurial they are tested with, or # be specifying the version(s) of Mercurial they are tested with, or
# leave the attribute unspecified. # leave the attribute unspecified.
testedwith = 'ships-with-hg-core' testedwith = 'ships-with-hg-core'
DEFAULT_SECTIONS = [ DEFAULT_SECTIONS = [
('feature', _('New Features')), ('feature', _('New Features')),
return False return False
else: else:
return False return False
def similaritycheck(incoming_str, existingnotes): def similaritycheck(incoming_str, existingnotes):
""" """
Returns false when note fragment can be merged to existing notes. Returns false when note fragment can be merged to existing notes.
""" """
try: # fuzzywuzzy not present
import fuzzywuzzy.fuzz as fuzz if not fuzz:
fuzz.token_set_ratio
except ImportError:
return True return True
merge = True merge = True
for bullet in existingnotes: for bullet in existingnotes:
score = fuzz.token_set_ratio(incoming_str, bullet) score = fuzz.token_set_ratio(incoming_str, bullet)
if score > 75: if score > 75:
merge = False merge = False
break break