( )⚙ D11249 check-module-imports: ignore non-stdlib module installed by distribution

This is an archive of the discontinued Mercurial Phabricator instance.

check-module-imports: ignore non-stdlib module installed by distribution
ClosedPublic

Authored by marmoute on Aug 3 2021, 1:49 PM.

Details

Summary

Previously, the check script would detect breezy as part of the stdlib if
installed using the debian package manager.

This silence the following complains:

tests/test-convert-bzr.t:117: imports not lexically sorted: breezy.bzr.bzrdir < sys
tests/test-convert-bzr.t:117: stdlib import "breezy.bzr.bzrdir" follows local import: breezy
tests/test-convert-bzr-ghosts.t:7: imports not lexically sorted: breezy.bzr.bzrdir < sys
tests/test-convert-bzr-ghosts.t:7: stdlib import "breezy.bzr.bzrdir" follows local import: breezy
tests/test-convert-bzr-treeroot.t:7: imports not lexically sorted: breezy.bzr.bzrdir < sys
tests/test-convert-bzr-treeroot.t:7: stdlib import "breezy.bzr.bzrdir" follows local import: breezy

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

marmoute created this revision.Aug 3 2021, 1:49 PM
pulkit accepted this revision.Aug 4 2021, 4:40 AM
This revision is now accepted and ready to land.Aug 4 2021, 4:40 AM
Alphare accepted this revision.Aug 4 2021, 9:11 AM