( )⚙ D1124 test-hgweb-annotate-whitespace: make test compatible with chg

This is an archive of the discontinued Mercurial Phabricator instance.

test-hgweb-annotate-whitespace: make test compatible with chg
ClosedPublic

Authored by singhsrb on Oct 16 2017, 4:07 PM.

Details

Summary

D946 fixed a bunch of tests which had the same root cause. Please see
that for details. This seems to be one of the newer tests which fails because
of the same reason.

Test Plan

Ran the test 'test-hgweb-annotate-whitespace.t' with and without the
'--chg' option.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

singhsrb created this revision.Oct 16 2017, 4:07 PM
quark accepted this revision.Oct 16 2017, 7:56 PM

I'm a bit worried that chg can't handle the typical argument pattern here...

durin42 accepted this revision.Oct 16 2017, 9:35 PM
This revision is now accepted and ready to land.Oct 16 2017, 9:35 PM

@durin42: That's a valid concern and I am planning to look at the pattern handling code at some point.

This revision was automatically updated to reflect the committed changes.
yuja added a subscriber: yuja.Oct 17 2017, 8:47 AM

@durin42: That's a valid concern and I am planning to look at the pattern handling code at some point.

Maybe we should instead make hg serve --daemon work under commandserver.
Argument parsing in chg.c is merely a hack to get around Mercurial bugs.