( )⚙ D11250 testing: make sure write_file is "atomic"

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D11250

testing: make sure write_file is "atomic"
ClosedPublic

Authored by marmoute on Aug 3 2021, 1:52 PM.

Download Raw Diff

Tags

None

Subscribers

mercurial-patches

Details

Reviewers

Group Reviewers

Commits

rHG5ad37164a8fe: testing: make sure write_file is "atomic"

Summary

This make sure viewer cannot see the new file with partial content.

This was likely the cause of some flakiness in test-nointerrupt.t

Diff Detail

Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

marmoute created this revision.Aug 3 2021, 1:52 PM

Herald added a reviewer: hg-reviewers. · View Herald TranscriptAug 3 2021, 1:52 PM

Herald added a subscriber: mercurial-patches. · View Herald Transcript

This does not seems to be all of the issue we have with nointerrupt.t … https://foss.heptapod.net/octobus/mercurial-devel/-/jobs/233269

marmoute added a child revision: D11251: test-nointerrupt: make "sure" the handler "might" trigger (issue6558).Aug 4 2021, 6:37 AM

Alphare accepted this revision.Aug 4 2021, 3:06 PM

This revision is now accepted and ready to land.Aug 4 2021, 3:06 PM

marmoute added a commit: rHG5ad37164a8fe: testing: make sure write_file is "atomic".Aug 5 2021, 5:14 AM

Closed by commit rHG5ad37164a8fe: testing: make sure write_file is "atomic" (authored by marmoute). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			mercurial/testing/__init__.py (8 lines)

Diff 29801

mercurial/testing/init.py

	start = time.time()			start = time.time()
	while not os.path.exists(path):			while not os.path.exists(path):
	if timeout and time.time() - start > timeout:			if timeout and time.time() - start > timeout:
	raise RuntimeError(b"timed out waiting for file: %s" % path)			raise RuntimeError(b"timed out waiting for file: %s" % path)
	time.sleep(0.01)			time.sleep(0.01)


	def write_file(path, content=b''):			def write_file(path, content=b''):
	with open(path, 'wb') as f:			if content:
				write_path = b'%s.tmp' % path
				else:
				write_path = path
				with open(write_path, 'wb') as f:
	f.write(content)			f.write(content)
				if path != write_path:
				os.rename(write_path, path)