( )⚙ D11360 pyoxidizer: default to a meaningless release instead of hardcoding 5.8

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D11360

pyoxidizer: default to a meaningless release instead of hardcoding 5.8
ClosedPublic

Authored by Alphare on Aug 27 2021, 8:41 AM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHG7f23a472068f: pyoxidizer: default to a meaningless release instead of hardcoding 5.8
Summary

This way we don't advertise the wrong version, or if we do it's really obvious.
To be honest, I'm not even sure that VERSION should be optional, but I also
have never used the packaging tools so far, this is simply something I saw.

Diff Detail

Repository
rHG Mercurial
Branch
stable
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

Alphare created this revision.Aug 27 2021, 8:41 AM
Alphare added a subscriber: indygreg.Aug 27 2021, 8:44 AM

@indygreg Probably interesting to you

pulkit accepted this revision.Aug 31 2021, 4:15 AM
This revision is now accepted and ready to land.Aug 31 2021, 4:15 AM

Revision Contents
Changeset List

PathPackages
Mrust/hgcli/pyoxidizer.bzl (2 lines)

Diff 30112

rust/hgcli/pyoxidizer.bzl

# String fragment in code signing certificate subject name used to find # String fragment in code signing certificate subject name used to find
# code signing certificate in Windows certificate store. # code signing certificate in Windows certificate store.
# #
# TIME_STAMP_SERVER_URL # TIME_STAMP_SERVER_URL
# URL of time-stamp token authority (RFC 3161) servers to stamp code signatures. # URL of time-stamp token authority (RFC 3161) servers to stamp code signatures.
ROOT = CWD + "/../.." ROOT = CWD + "/../.."
VERSION = VARS.get("VERSION", "5.8") VERSION = VARS.get("VERSION", "0.0")
MSI_NAME = VARS.get("MSI_NAME", "mercurial") MSI_NAME = VARS.get("MSI_NAME", "mercurial")
EXTRA_MSI_FEATURES = VARS.get("EXTRA_MSI_FEATURES") EXTRA_MSI_FEATURES = VARS.get("EXTRA_MSI_FEATURES")
SIGNING_PFX_PATH = VARS.get("SIGNING_PFX_PATH") SIGNING_PFX_PATH = VARS.get("SIGNING_PFX_PATH")
SIGNING_PFX_PASSWORD = VARS.get("SIGNING_PFX_PASSWORD", "") SIGNING_PFX_PASSWORD = VARS.get("SIGNING_PFX_PASSWORD", "")
SIGNING_SUBJECT_NAME = VARS.get("SIGNING_SUBJECT_NAME") SIGNING_SUBJECT_NAME = VARS.get("SIGNING_SUBJECT_NAME")
TIME_STAMP_SERVER_URL = VARS.get("TIME_STAMP_SERVER_URL", "http://timestamp.digicert.com") TIME_STAMP_SERVER_URL = VARS.get("TIME_STAMP_SERVER_URL", "http://timestamp.digicert.com")
IS_WINDOWS = "windows" in BUILD_TARGET_TRIPLE IS_WINDOWS = "windows" in BUILD_TARGET_TRIPLE