( )⚙ D11380 rhg: fallback if the current command has any generic hook defined

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D11380

rhg: fallback if the current command has any generic hook defined
ClosedPublic

Authored by Alphare on Sep 1 2021, 12:43 PM.

Details

Reviewers
SimonSapin
Group Reviewers
hg-reviewers
Commits
rHGf11f233546ce: rhg: fallback if the current command has any generic hook defined
Summary

We do not handle hooks yet.

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

Alphare created this revision.Sep 1 2021, 12:43 PM
SimonSapin accepted this revision.Sep 2 2021, 2:36 PM
SimonSapin added a subscriber: SimonSapin.
SimonSapin added inline comments.
rust/rhg/src/main.rs
72

Nit: "string literals" have type &'static str, so the extra & operators are unnecessary. (This prefix ends up with triple pointer indirection &&&str since .iter() adds another one! But by-value array iteration requires Rust 1.53)

Alphare added inline comments.Sep 3 2021, 5:43 AM
rust/rhg/src/main.rs
72

Ah, I got confused since I started with b"pre" instead of b"pre", which doesn't work since the items differed in size, but it does not apply to &'static str, as you mentioned.
We're gonna have to wait for Debian Bookworm for 1.53 I'm pretty sure. ;)

SimonSapin added inline comments.Sep 9 2021, 9:37 AM
rust/rhg/src/main.rs
72

Ah yes, I only mentioned by value iteration in passing :)

Alphare updated this revision to Diff 30204.Sep 10 2021, 6:10 PM
SimonSapin accepted this revision.Sep 14 2021, 3:55 AM
Alphare added a commit: rHGf11f233546ce: rhg: fallback if the current command has any generic hook defined.Oct 1 2021, 9:21 AM
This revision was not accepted when it landed; it landed in state Needs Review.
Closed by commit rHGf11f233546ce: rhg: fallback if the current command has any generic hook defined (authored by Alphare). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mrust/rhg/src/main.rs (11 lines)
Mtests/test-rhg.t (13 lines)

Diff 30170

rust/rhg/src/main.rs

.global(true), .global(true),
) )
.version("0.0.1"); .version("0.0.1");
let app = add_subcommand_args(app); let app = add_subcommand_args(app);
let matches = app.clone().get_matches_safe()?; let matches = app.clone().get_matches_safe()?;
let (subcommand_name, subcommand_matches) = matches.subcommand(); let (subcommand_name, subcommand_matches) = matches.subcommand();
for prefix in [&"pre", &"post", &"fail"].iter() {
SimonSapinUnsubmitted
Not Done

Nit: "string literals" have type &'static str, so the extra & operators are unnecessary. (This prefix ends up with triple pointer indirection &&&str since .iter() adds another one! But by-value array iteration requires Rust 1.53)

SimonSapin: Nit: `"string literals"` have type `&'static str`, so the extra `&` operators are unnecessary.
AlphareAuthorUnsubmitted
Done

Ah, I got confused since I started with b"pre" instead of b"pre", which doesn't work since the items differed in size, but it does not apply to &'static str, as you mentioned.
We're gonna have to wait for Debian Bookworm for 1.53 I'm pretty sure. ;)

Alphare: Ah, I got confused since I started with `b"pre"` instead of `b"pre"`, which doesn't work since…
SimonSapinUnsubmitted
Not Done

Ah yes, I only mentioned by value iteration in passing :)

SimonSapin: Ah yes, I only mentioned by value iteration in passing :)
// Mercurial allows users to define generic hooks for commands,
// fallback if any are detected
let item = format!("{}-{}", prefix, subcommand_name);
let hook_for_command = config.get_str(b"hooks", item.as_bytes())?;
if hook_for_command.is_some() {
let msg = format!("{}-{} hook defined", prefix, subcommand_name);
return Err(CommandError::unsupported(msg));
}
}
let run = subcommand_run_fn(subcommand_name) let run = subcommand_run_fn(subcommand_name)
.expect("unknown subcommand name from clap despite AppSettings::SubcommandRequired"); .expect("unknown subcommand name from clap despite AppSettings::SubcommandRequired");
let subcommand_args = subcommand_matches let subcommand_args = subcommand_matches
.expect("no subcommand arguments from clap despite AppSettings::SubcommandRequired"); .expect("no subcommand arguments from clap despite AppSettings::SubcommandRequired");
let invocation = CliInvocation { let invocation = CliInvocation {
ui, ui,
subcommand_args, subcommand_args,

tests/test-rhg.t

unsupported feature: `..` or `.` path segment unsupported feature: `..` or `.` path segment
[252] [252]
Fallback with filesets Fallback with filesets
$ $NO_FALLBACK rhg cat "set:c or b" $ $NO_FALLBACK rhg cat "set:c or b"
unsupported feature: fileset unsupported feature: fileset
[252] [252]
Fallback with generic hooks
$ $NO_FALLBACK rhg cat original --config hooks.pre-cat=something
unsupported feature: pre-cat hook defined
[252]
$ $NO_FALLBACK rhg cat original --config hooks.post-cat=something
unsupported feature: post-cat hook defined
[252]
$ $NO_FALLBACK rhg cat original --config hooks.fail-cat=something
unsupported feature: fail-cat hook defined
[252]
Requirements Requirements
$ $NO_FALLBACK rhg debugrequirements $ $NO_FALLBACK rhg debugrequirements
dotencode dotencode
fncache fncache
generaldelta generaldelta
persistent-nodemap persistent-nodemap
revlog-compression-zstd (zstd !) revlog-compression-zstd (zstd !)
revlogv1 revlogv1