This is an archive of the discontinued Mercurial Phabricator instance.

Differential D11385

dirstate-item: factor some code in the C implementation
ClosedPublic

Authored by marmoute on Sep 1 2021, 7:36 PM.

Details

Reviewers
Alphare
Group Reviewers
hg-reviewers
Commits
rHG0919d66e279a: dirstate-item: factor some code in the C implementation
Summary

We have both dirstate_item_from_v1_meth, a class method, and
dirstate_item_from_v1_data, a function taking low level C argument.

Lets implement the former with the later.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

marmoute created this revision.Sep 1 2021, 7:36 PM
Alphare accepted this revision.Sep 8 2021, 9:26 AM
This revision is now accepted and ready to land.Sep 8 2021, 9:26 AM
marmoute added a commit: rHG0919d66e279a: dirstate-item: factor some code in the C implementation.Sep 9 2021, 5:13 AM
Closed by commit rHG0919d66e279a: dirstate-item: factor some code in the C implementation (authored by marmoute). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 30191

mercurial/cext/parsers.c

} }
/* This will never change since it's bound to V1, unlike `dirstate_item_new` */ /* This will never change since it's bound to V1, unlike `dirstate_item_new` */
static PyObject *dirstate_item_from_v1_meth(PyTypeObject *subtype, static PyObject *dirstate_item_from_v1_meth(PyTypeObject *subtype,
PyObject *args) PyObject *args)
{ {
/* We do all the initialization here and not a tp_init function because /* We do all the initialization here and not a tp_init function because
* dirstate_item is immutable. */ * dirstate_item is immutable. */
dirstateItemObject *t;
char state; char state;
int size, mode, mtime; int size, mode, mtime;
if (!PyArg_ParseTuple(args, "ciii", &state, &mode, &size, &mtime)) { if (!PyArg_ParseTuple(args, "ciii", &state, &mode, &size, &mtime)) {
return NULL; return NULL;
} }
return (PyObject *)dirstate_item_from_v1_data(state, mode, size, mtime);
t = (dirstateItemObject *)subtype->tp_alloc(subtype, 1);
if (!t) {
return NULL;
}
t->state = state;
t->mode = mode;
t->size = size;
t->mtime = mtime;
return (PyObject *)t;
}; };
/* constructor to help legacy API to build a new "added" item /* constructor to help legacy API to build a new "added" item
Should eventually be removed */ Should eventually be removed */
static PyObject *dirstate_item_new_added(PyTypeObject *subtype) static PyObject *dirstate_item_new_added(PyTypeObject *subtype)
{ {
dirstateItemObject *t; dirstateItemObject *t;