This is an archive of the discontinued Mercurial Phabricator instance.

Status	Author	Revision
Closed	marmoute	D11387 dirstate-item: move the C implementation to the same logic
Closed	marmoute	D11386 dirstate-item: introduce low level C function
Closed	marmoute	D11385 dirstate-item: factor some code in the C implementation
Closed	marmoute	D11384 dirstate-item: `dirstate_item_from_v1_data` replaces make_dirstate_item
Closed	marmoute	D11383 pathutil: replace the `skip` argument of `dirs` with a boolean
Closed	marmoute	D11382 dirstate: clarify the message in nonnormal checking

Diff 30175

	}			}

	/* This will never change since it's bound to V1, unlike `dirstate_item_new` */			/* This will never change since it's bound to V1, unlike `dirstate_item_new` */
	static PyObject dirstate_item_from_v1_meth(PyTypeObject subtype,			static PyObject dirstate_item_from_v1_meth(PyTypeObject subtype,
	PyObject *args)			PyObject *args)
	{			{
	/* We do all the initialization here and not a tp_init function because			/* We do all the initialization here and not a tp_init function because
	* dirstate_item is immutable. */			* dirstate_item is immutable. */
	dirstateItemObject *t;
	char state;			char state;
	int size, mode, mtime;			int size, mode, mtime;
	if (!PyArg_ParseTuple(args, "ciii", &state, &mode, &size, &mtime)) {			if (!PyArg_ParseTuple(args, "ciii", &state, &mode, &size, &mtime)) {
	return NULL;			return NULL;
	}			}
				return (PyObject *)dirstate_item_from_v1_data(state, mode, size, mtime);
	t = (dirstateItemObject *)subtype->tp_alloc(subtype, 1);
	if (!t) {
	return NULL;
	}
	t->state = state;
	t->mode = mode;
	t->size = size;
	t->mtime = mtime;

	return (PyObject *)t;
	};			};

	/* constructor to help legacy API to build a new "added" item			/* constructor to help legacy API to build a new "added" item

	Should eventually be removed */			Should eventually be removed */
	static PyObject dirstate_item_new_added(PyTypeObject subtype)			static PyObject dirstate_item_new_added(PyTypeObject subtype)
	{			{
	dirstateItemObject *t;			dirstateItemObject *t;