( )⚙ D11402 rust-revset: support explicit `.` revision

This is an archive of the discontinued Mercurial Phabricator instance.

rust-revset: support explicit `.` revision
ClosedPublic

Authored by Alphare on Sep 10 2021, 6:10 PM.

Details

Summary

This is basically the same thing as not specifying a revision, except this is
done in the revset resolution function.

This allows calls like rhg cat some-file -r . to work without falling back.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Alphare created this revision.Sep 10 2021, 6:10 PM
Alphare planned changes to this revision.Sep 13 2021, 8:21 AM

Turns out there is a small problem with git subrepos, I'll fix that.

Alphare updated this revision to Diff 30219.Sep 13 2021, 11:39 AM
SimonSapin accepted this revision.Sep 14 2021, 11:13 AM
martinvonz added inline comments.
rust/hg-core/src/revset.rs
24

I've changed this to rev_for_node to account for D11415 getting queued since you sent this.

I pushed this series to hg-committed many hours ago. I thought that used to close the review, but it's still open here. Any idea why?

I pushed this series to hg-committed many hours ago. I thought that used to close the review, but it's still open here. Any idea why?

Looks like some of the infra is broken because of bad Let's Encrypt certificates, which unfortunately includes this as well as the Heptapod sync. I'll try to look into it.

rust/hg-core/src/revset.rs
24

Thanks!

This revision was not accepted when it landed; it landed in state Needs Review.
This revision was automatically updated to reflect the committed changes.