This is an archive of the discontinued Mercurial Phabricator instance.

Differential D11473

util: eliminate the possibility of returning None from `versiontuple()`
ClosedPublic

Authored by mharbison72 on Sep 21 2021, 11:38 AM.

Details

Reviewers
Alphare
Group Reviewers
hg-reviewers
Commits
rHG376d08ae904f: util: eliminate the possibility of returning None from `versiontuple()`
Summary

This fixes the following error flagged by pytype:

File "/mnt/c/Users/Matt/hg/mercurial/extensions.py", line 228, in load: unsupported operand types for > [unsupported-operands]
  Primitive types 'Optional[tuple]' and 'curver: Optional[tuple]' are not comparable.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Revision Contents
Changeset List

PathPackages
Mmercurial/util.py (2 lines)

Diff 30365

mercurial/util.py

if n == 2: if n == 2:
return (vints[0], vints[1]) return (vints[0], vints[1])
if n == 3: if n == 3:
return (vints[0], vints[1], vints[2]) return (vints[0], vints[1], vints[2])
if n == 4: if n == 4:
return (vints[0], vints[1], vints[2], extra) return (vints[0], vints[1], vints[2], extra)
raise error.ProgrammingError(b"invalid version part request: %d" % n)
def cachefunc(func): def cachefunc(func):
'''cache the result of function calls''' '''cache the result of function calls'''
# XXX doesn't handle keywords args # XXX doesn't handle keywords args
if func.__code__.co_argcount == 0: if func.__code__.co_argcount == 0:
listcache = [] listcache = []
def f(): def f():