Page MenuHomePhabricator

extensions: prevent a crash on py3 when testing a bad extension minimum
ClosedPublic

Authored by mharbison72 on Sep 21 2021, 11:38 AM.

Details

Summary

A None placeholder is populated for each missing component by
util.versiontuple(), which could safely be used with > on py2, but not py3.
I guess there's another hole here where if the string is entirely bogus (i.e no
numbers), it will be treated as 0.0, and always load. But that's always been
the case.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.