This is an archive of the discontinued Mercurial Phabricator instance.

Differential D116

run-tests: drop unnecessary check for pygmentspresent
ClosedPublic

Authored by martinvonz on Jul 17 2017, 8:05 PM.

Details

Reviewers
krbullock
Group Reviewers
hg-reviewers
Commits
rHG97070cbf0813: run-tests: drop unnecessary check for pygmentspresent
rHGf934f272b31d: run-tests: drop unnecessary check for pygmentspresent
Summary

b6b5e994fae5 (run-tests: check if stream is a tty before using color,
2017-07-18) made the check redundant but forgot to remove it.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

martinvonz created this revision.Jul 17 2017, 8:05 PM
martinvonz edited the summary of this revision. (Show Details)Jul 18 2017, 12:13 PM
martinvonz retitled this revision from run-tests: check pygmentspresent in parseargs() to run-tests: drop unnecessary check for pygmentspresent.
martinvonz updated this revision to Diff 253.
martinvonz updated this revision to Diff 258.Jul 18 2017, 12:58 PM
krbullock accepted this revision.Jul 18 2017, 3:19 PM
krbullock added a subscriber: krbullock.

Queued, thanks.

This revision is now accepted and ready to land.Jul 18 2017, 3:19 PM
Closed by commit rHGf934f272b31d: run-tests: drop unnecessary check for pygmentspresent (authored by martinvonz). · Explain WhyJul 18 2017, 3:26 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mtests/run-tests.py (2 lines)

Diff 284

tests/run-tests.py

servefail, lines = getdiff(expected, got, servefail, lines = getdiff(expected, got,
test.refpath, test.errpath) test.refpath, test.errpath)
if servefail: if servefail:
raise test.failureException( raise test.failureException(
'server failed to start (HGPORT=%s)' % test._startport) 'server failed to start (HGPORT=%s)' % test._startport)
else: else:
self.stream.write('\n') self.stream.write('\n')
for line in lines: for line in lines:
if self.color and pygmentspresent: if self.color:
line = pygments.highlight( line = pygments.highlight(
line, line,
lexers.DiffLexer(), lexers.DiffLexer(),
formatters.Terminal256Formatter()) formatters.Terminal256Formatter())
if PYTHON3: if PYTHON3:
self.stream.flush() self.stream.flush()
self.stream.buffer.write(line) self.stream.buffer.write(line)
self.stream.buffer.flush() self.stream.buffer.flush()