This is an archive of the discontinued Mercurial Phabricator instance.

Differential D117

run-tests: warn if --color=always and no pygments installed
ClosedPublic

Authored by martinvonz on Jul 17 2017, 8:05 PM.

Details

Reviewers
krbullock
Group Reviewers
hg-reviewers
Commits
rHGd9677e2ed16a: run-tests: warn if --color=always and no pygments installed
rHG63f2445079da: run-tests: warn if --color=always and no pygments installed
Summary

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

martinvonz created this revision.Jul 17 2017, 8:05 PM
yuja added a subscriber: yuja.Jul 18 2017, 10:54 AM
yuja added inline comments.
tests/run-tests.py
415–420

Nit: missing space after "because".

martinvonz marked an inline comment as done.Jul 18 2017, 11:37 AM
martinvonz added inline comments.
tests/run-tests.py
415–420

Good catch. I had fixed that, but then lost it in a rebase.

martinvonz marked an inline comment as done.Jul 18 2017, 12:13 PM
martinvonz updated this revision to Diff 254.
krbullock accepted this revision.Jul 18 2017, 3:19 PM
krbullock added a subscriber: krbullock.

Queued, thanks.

This revision is now accepted and ready to land.Jul 18 2017, 3:19 PM
Closed by commit rHG63f2445079da: run-tests: warn if --color=always and no pygments installed (authored by martinvonz). · Explain WhyJul 18 2017, 3:27 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mtests/run-tests.py (4 lines)

Diff 285

tests/run-tests.py

options.with_chg = canonpath(_bytespath(options.with_chg)) options.with_chg = canonpath(_bytespath(options.with_chg))
if not (os.path.isfile(options.with_chg) and if not (os.path.isfile(options.with_chg) and
os.access(options.with_chg, os.X_OK)): os.access(options.with_chg, os.X_OK)):
parser.error('--with-chg must specify a chg executable') parser.error('--with-chg must specify a chg executable')
if options.chg and options.with_hg: if options.chg and options.with_hg:
# chg shares installation location with hg # chg shares installation location with hg
parser.error('--chg does not work when --with-hg is specified ' parser.error('--chg does not work when --with-hg is specified '
'(use --with-chg instead)') '(use --with-chg instead)')
if options.color == 'always' and not pygmentspresent:
sys.stderr.write('warning: --color=always ignored because '
'pygments is not installed\n')
global useipv6 global useipv6
yujaUnsubmitted
Done

Nit: missing space after "because".

yuja: Nit: missing space after "because".
martinvonzAuthorUnsubmitted
Not Done

Good catch. I had fixed that, but then lost it in a rebase.

martinvonz: Good catch. I had fixed that, but then lost it in a rebase.
if options.ipv6: if options.ipv6:
useipv6 = checksocketfamily('AF_INET6') useipv6 = checksocketfamily('AF_INET6')
else: else:
# only use IPv6 if IPv4 is unavailable and IPv6 is available # only use IPv6 if IPv4 is unavailable and IPv6 is available
useipv6 = ((not checksocketfamily('AF_INET')) useipv6 = ((not checksocketfamily('AF_INET'))
and checksocketfamily('AF_INET6')) and checksocketfamily('AF_INET6'))
options.anycoverage = options.cover or options.annotate or options.htmlcov options.anycoverage = options.cover or options.annotate or options.htmlcov