Thanks, I did not know that was supported in vanilla hg.
This broke a Rust unit test: https://foss.heptapod.net/mercurial/mercurial-devel/-/jobs/253010#L32
You can run these tests with (cd rust && cargo test). Could you send a follow-up patch to fix this?
This breaks the CI: https://foss.heptapod.net/mercurial/mercurial-devel/-/jobs/254045
It seems that the previous assumption made in the code was that null revs were to be shortcut and this assumption was not changed everywhere. @aalekseyev The easiest way of making sure you're not breaking anything is to push a topic to https://foss.heptapod.net/mercurial/mercurial-devel (if you create an account I can give you the rights to do so).
Right now other tests are failing, so you might see unrelated failures, but I'm looking into those as well. I try to keep the CI is mostly green, but I was on vacation.
Does the test suite already have a test for empty manifest or is this specific to rhg? I'm asking because I don't think mixing rhg config options within "normal tests" is a good idea. There is test-rhg.t that is specifically done to test the differences (or lack thereof) and the fallback mechanism.
I couldn't find an existing test for null manifest revision.
Oh, yeah, I added those temporarily to make sure I was testing what I thought I was testing.
Sure, me neither, that's fine. :)
I would have preferred not to have those at all and to have waiting for the fix, but I guess the churn is not worth it anymore. Thanks for fixing the issues, I'm trying to catch up to what happened. :)