This is an archive of the discontinued Mercurial Phabricator instance.

Differential D11653

chistedit: rename a confusingly named variable
ClosedPublic

Authored by martinvonz on Oct 12 2021, 5:31 PM.

Details

Reviewers
durin42
pulkit
Group Reviewers
hg-reviewers
Commits
rHGd8cff8564f5a: chistedit: rename a confusingly named variable
Summary

I would expect ctxs contain instances of some class from the
context module but it actually contains instances of histeditrule.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

martinvonz created this revision.Oct 12 2021, 5:31 PM
pulkit accepted this revision.Oct 13 2021, 3:10 PM
This revision is now accepted and ready to land.Oct 13 2021, 3:10 PM
martinvonz added a commit: rHGd8cff8564f5a: chistedit: rename a confusingly named variable.Oct 13 2021, 6:28 PM
Closed by commit rHGd8cff8564f5a: chistedit: rename a confusingly named variable (authored by martinvonz). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mhgext/histedit.py (6 lines)

Diff 30791

hgext/histedit.py

topmost = repo.dirstate.p1() topmost = repo.dirstate.p1()
revs = between(repo, root, topmost, keep) revs = between(repo, root, topmost, keep)
if not revs: if not revs:
raise error.InputError( raise error.InputError(
_(b'%s is not an ancestor of working directory') % short(root) _(b'%s is not an ancestor of working directory') % short(root)
) )
ctxs = [] rules = []
for i, r in enumerate(revs): for i, r in enumerate(revs):
ctxs.append(histeditrule(ui, repo[r], i)) rules.append(histeditrule(ui, repo[r], i))
with util.with_lc_ctype(): with util.with_lc_ctype():
rc = curses.wrapper(functools.partial(_chisteditmain, repo, ctxs)) rc = curses.wrapper(functools.partial(_chisteditmain, repo, rules))
curses.echo() curses.echo()
curses.endwin() curses.endwin()
if rc is False: if rc is False:
ui.write(_(b"histedit aborted\n")) ui.write(_(b"histedit aborted\n"))
return 0 return 0
if type(rc) is list: if type(rc) is list:
ui.status(_(b"performing changes\n")) ui.status(_(b"performing changes\n"))
rules = makecommands(rc) rules = makecommands(rc)