This is an archive of the discontinued Mercurial Phabricator instance.

Differential D11658

dirstate: Remove unused variable
ClosedPublic

Authored by SimonSapin on Oct 14 2021, 8:00 AM.

Download Raw Diff

Tags

None

Subscribers

mercurial-patches

Details

Reviewers

Group Reviewers

Commits

rHG50dca3aa5c3b: dirstate: Remove unused variable

Summary

This fixes test-check-pyflakes.t which is currently failing
on the default branch.

Diff Detail

Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

SimonSapin created this revision.Oct 14 2021, 8:00 AM

Herald added a reviewer: hg-reviewers. · View Herald TranscriptOct 14 2021, 8:00 AM

Herald added a subscriber: mercurial-patches. · View Herald Transcript

SimonSapin added a child revision: D11660: dirstate-v2: Use attributes as intended instead of properties in v2_data().Oct 14 2021, 9:05 AM

pulkit accepted this revision.Oct 14 2021, 2:40 PM

This revision is now accepted and ready to land.Oct 14 2021, 2:40 PM

SimonSapin added a commit: rHG50dca3aa5c3b: dirstate: Remove unused variable.Oct 14 2021, 6:35 PM

Closed by commit rHG50dca3aa5c3b: dirstate: Remove unused variable (authored by SimonSapin). · Explain Why

This revision was automatically updated to reflect the committed changes.

martinvonz mentioned this in D11666: dirstate-v2: delete unused variable (to make test-check-pyflakes.t happy).Oct 14 2021, 8:27 PM

Revision Contents
Changeset List

			Path	Packages
M			mercurial/dirstateutils/v2.py (1 line)

Diff 30815

mercurial/dirstateutils/v2.py

	copy_source_start = 0			copy_source_start = 0
	copy_source_len = 0			copy_source_len = 0
	if entry is not None:			if entry is not None:
	flags, size, mtime_s = entry.v2_data()			flags, size, mtime_s = entry.v2_data()
	mtime_ns = 0			mtime_ns = 0
	else:			else:
	# There are no mtime-cached directories in the Python implementation			# There are no mtime-cached directories in the Python implementation
	flags = 0			flags = 0
	mode = 0
	size = 0			size = 0
	mtime_s = 0			mtime_s = 0
	mtime_ns = 0			mtime_ns = 0
	return NODE.pack(			return NODE.pack(
	path_start,			path_start,
	path_len,			path_len,
	basename_start,			basename_start,
	copy_source_start,			copy_source_start,