Page MenuHomePhabricator

chistedit: add option to show order of commits in opposite order
ClosedPublic

Authored by martinvonz on Oct 15 2021, 1:14 AM.

Details

Summary

Many users (including me) expect the order of commits in histedit to
match the order in hg log -G and are confused because it
doesnn't. This patch adds an option to show later commits first in the
list. I've only added support for it in chistedit for now. As a
consequence, I've marked the config option experimental (I think it
should apply to both interfaces before it graduates).

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

martinvonz created this revision.Oct 15 2021, 1:14 AM
pulkit accepted this revision.Oct 15 2021, 8:43 AM
This revision is now accepted and ready to land.Oct 15 2021, 8:43 AM

Doing cross review: is there any indication of the direction of history when the UI pops up, or does the user just have to figure it out?

Doing cross review: is there any indication of the direction of history when the UI pops up, or does the user just have to figure it out?

The user will have to figure it out (hopefully they remembered if they set the config option). Internally at Google, I was going to override helplines() (and some other function which I've forgotten now) to make it print a red banner saying if the direction has changed.

Doing cross review: is there any indication of the direction of history when the UI pops up, or does the user just have to figure it out?

The user will have to figure it out (hopefully they remembered if they set the config option). Internally at Google, I was going to override helplines() (and some other function which I've forgotten now) to make it print a red banner saying if the direction has changed.

Could I get a follow-up of some kind that prints some advice for users about this in all cases? It seems like even if we don't change the default, we should just tell people. Maybe in plain-text histedit too, but I worry less about that since curses gets more mindshare.

Doing cross review: is there any indication of the direction of history when the UI pops up, or does the user just have to figure it out?

The user will have to figure it out (hopefully they remembered if they set the config option). Internally at Google, I was going to override helplines() (and some other function which I've forgotten now) to make it print a red banner saying if the direction has changed.

Could I get a follow-up of some kind that prints some advice for users about this in all cases? It seems like even if we don't change the default, we should just tell people. Maybe in plain-text histedit too, but I worry less about that since curses gets more mindshare.

Sure, I could send a patch for adding another line to the help text. Do you think that's clear enough? I don't know where else it would go. (We would probably still want to override it internally to highlight it when we roll it out to Google devs.)

Sure, I could send a patch for adding another line to the help text. Do you think that's clear enough? I don't know where else it would go. (We would probably still want to override it internally to highlight it when we roll it out to Google devs.)

Probably, maybe show me some screenshots (internal chat is fine) of what you have in mind?