Page MenuHomePhabricator

path: add a new argument to control path validation
ClosedPublic

Authored by marmoute on Oct 15 2021, 4:18 AM.

Details

Summary

During pull, unvalidated path might be used, having the option to do so directly will allow use to simplify some code and unlock more path usage later in the series.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

marmoute created this revision.Oct 15 2021, 4:18 AM
pulkit accepted this revision.Oct 15 2021, 8:51 AM
This revision is now accepted and ready to land.Oct 15 2021, 8:51 AM
Alphare added inline comments.
mercurial/utils/urlutil.py
834

This docstring is outdated. Could you also add validate_path in the same change?

marmoute updated this revision to Diff 30855.Oct 18 2021, 6:02 AM
marmoute added inline comments.Oct 18 2021, 6:08 AM
mercurial/utils/urlutil.py
834

indeed, this should be fixed now.

marmoute updated this revision to Diff 30861.Oct 18 2021, 6:20 AM
marmoute added inline comments.Oct 18 2021, 6:21 AM
mercurial/utils/urlutil.py
834

Actually the docstring is not about the init parameters but about the attributes ? (maybe?) and seems quite outdate. I'll clean this up independently.

Alphare accepted this revision.Oct 18 2021, 7:49 AM
This revision was automatically updated to reflect the committed changes.