( )⚙ D1167 makefile: add target to apply clang-format in-place

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D1167

makefile: add target to apply clang-format in-place
ClosedPublic

Authored by durin42 on Oct 17 2017, 5:44 PM.

Details

Reviewers
indygreg
Group Reviewers
hg-reviewers
Commits
rHG2bf152128d59: makefile: add target to apply clang-format in-place
Summary

This makes it easy to reformat files after you finish editing them.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

durin42 created this revision.Oct 17 2017, 5:44 PM
indygreg accepted this revision.Oct 18 2017, 11:45 AM
This revision is now accepted and ready to land.Oct 18 2017, 11:45 AM
Closed by commit rHG2bf152128d59: makefile: add target to apply clang-format in-place (authored by durin42). · Explain WhyOct 18 2017, 11:51 AM
This revision was automatically updated to reflect the committed changes.
av6 added a subscriber: av6.Oct 25 2017, 11:42 PM

I'm a bit late to the party, but wanted to remind people that targets that are not actual files (in this case, a file named "format-c") should also go into .PHONY list. Nothing bad will happen right now (unless such file appears at some point), but adding it to "phony" targets helps keeping makefile in proper shape. (Looking at the already unwieldy .PHONY list I wish Make had another way to mark targets "phony").

durin42 added a comment.Oct 25 2017, 11:47 PM

d'oh - could you send a patch to fix that?

av6 added a comment.Oct 26 2017, 12:01 AM

Yep, mailed.

Revision Contents
Changeset List

PathPackages
MMakefile (4 lines)

Diff 2949

Makefile

[ -e $(HGPYTHONS)/$*/bin/python ] || ( \ [ -e $(HGPYTHONS)/$*/bin/python ] || ( \
cd $$(mktemp --directory --tmpdir) && \ cd $$(mktemp --directory --tmpdir) && \
$(MAKE) -f $(HGROOT)/contrib/Makefile.python PYTHONVER=$* PREFIX=$(HGPYTHONS)/$* python ) $(MAKE) -f $(HGROOT)/contrib/Makefile.python PYTHONVER=$* PREFIX=$(HGPYTHONS)/$* python )
cd tests && $(HGPYTHONS)/$*/bin/python run-tests.py $(TESTFLAGS) cd tests && $(HGPYTHONS)/$*/bin/python run-tests.py $(TESTFLAGS)
check-code: check-code:
hg manifest | xargs python contrib/check-code.py hg manifest | xargs python contrib/check-code.py
format-c:
clang-format --style file -i \
`hg files 'set:(**.c or **.h) and not "listfile:contrib/clang-format-blacklist"'`
update-pot: i18n/hg.pot update-pot: i18n/hg.pot
i18n/hg.pot: $(PYFILES) $(DOCFILES) i18n/posplit i18n/hggettext i18n/hg.pot: $(PYFILES) $(DOCFILES) i18n/posplit i18n/hggettext
$(PYTHON) i18n/hggettext mercurial/commands.py \ $(PYTHON) i18n/hggettext mercurial/commands.py \
hgext/*.py hgext/*/__init__.py \ hgext/*.py hgext/*/__init__.py \
mercurial/fileset.py mercurial/revset.py \ mercurial/fileset.py mercurial/revset.py \
mercurial/templatefilters.py mercurial/templatekw.py \ mercurial/templatefilters.py mercurial/templatekw.py \
mercurial/templater.py \ mercurial/templater.py \