This is an archive of the discontinued Mercurial Phabricator instance.

rhg: simplify split_metadata

Authored by aalekseyev on Oct 19 2021, 5:53 AM.



It turns out that it's possible to implement FilelogEntry.into_data
on top of split, as proposed by @spectral.

Diff Detail

rHG Mercurial
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

aalekseyev created this revision.Oct 19 2021, 5:53 AM
Alphare accepted this revision.Oct 19 2021, 7:35 AM
Alphare added a subscriber: Alphare.

That looks good, thanks.

FYI these patches are normally not supposed to be taken during a freeze, but rhg is sufficiently experimental and it takes up low enough overhead to review those patches that they can go in now. It'll make it easier for Jane Street to maintain their fork so that's also an added bonus.

This revision is now accepted and ready to land.Oct 19 2021, 7:35 AM

Thanks, good to know. I did not realize there was a freeze.

This revision was automatically updated to reflect the committed changes.