( )⚙ D11711 parsers: don't ask about the exec bit on platforms that don't have it

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D11711

parsers: don't ask about the exec bit on platforms that don't have it
ClosedPublic

Authored by Alphare on Oct 20 2021, 1:07 PM.

Details

Reviewers
spectral
Group Reviewers
hg-reviewers
Commits
rHG249d1888e9d8: parsers: don't ask about the exec bit on platforms that don't have it
Summary

Otherwise the compiler gets quite sad.

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

Alphare created this revision.Oct 20 2021, 1:07 PM
spectral accepted this revision.Oct 20 2021, 2:13 PM
baymax updated this revision to Diff 30974.Oct 21 2021, 1:50 PM

✅ refresh by Heptapod after a successful CI run (🐙 💚)

Alphare added a commit: rHG249d1888e9d8: parsers: don't ask about the exec bit on platforms that don't have it.Oct 24 2021, 1:06 AM
This revision was not accepted when it landed; it landed in state Needs Review.
Closed by commit rHG249d1888e9d8: parsers: don't ask about the exec bit on platforms that don't have it (authored by Alphare). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/cext/parsers.c (5 lines)

Diff 30974

mercurial/cext/parsers.c

return self->mtime_s; return self->mtime_s;
} }
} }
static PyObject *dirstate_item_v2_data(dirstateItemObject *self) static PyObject *dirstate_item_v2_data(dirstateItemObject *self)
{ {
int flags = self->flags; int flags = self->flags;
int mode = dirstate_item_c_v1_mode(self); int mode = dirstate_item_c_v1_mode(self);
#ifdef S_IXUSR
/* This is for platforms with an exec bit */
if ((mode & S_IXUSR) != 0) { if ((mode & S_IXUSR) != 0) {
flags |= dirstate_flag_mode_exec_perm; flags |= dirstate_flag_mode_exec_perm;
} else { } else {
flags &= ~dirstate_flag_mode_exec_perm; flags &= ~dirstate_flag_mode_exec_perm;
} }
#else
flags &= ~dirstate_flag_mode_exec_perm;
#endif
if (S_ISLNK(mode)) { if (S_ISLNK(mode)) {
flags |= dirstate_flag_mode_is_symlink; flags |= dirstate_flag_mode_is_symlink;
} else { } else {
flags &= ~dirstate_flag_mode_is_symlink; flags &= ~dirstate_flag_mode_is_symlink;
} }
return Py_BuildValue("iiii", flags, self->size, self->mtime_s, return Py_BuildValue("iiii", flags, self->size, self->mtime_s,
self->mtime_ns); self->mtime_ns);
}; };