This is an archive of the discontinued Mercurial Phabricator instance.

Diff	ID	Description	Created	Lint	Unit
Base		Base
Diff 1	30958		Oct 20 2021, 1:07 PM	★	★
Diff 2	30975		Oct 21 2021, 1:50 PM	★	★
Diff 3	30982	rHG126feb805247ab25fca6fc2d84670b4cddcf476c	Oct 20 2021, 12:25 PM	★	★

Status	Author	Revision
Closed	Alphare	D11715 dirstate: group return logic and clarify each function in flagfunc
Closed	Alphare	D11713 dirstate: add missing return on platforms without exec or symlink
Closed	Alphare	D11712 parsers: don't ask about symlinks on platforms that don't support them
Closed	Alphare	D11711 parsers: don't ask about the exec bit on platforms that don't have it

Diff 30982

	if ((mode & S_IXUSR) != 0) {			if ((mode & S_IXUSR) != 0) {
	flags \|= dirstate_flag_mode_exec_perm;			flags \|= dirstate_flag_mode_exec_perm;
	} else {			} else {
	flags &= ~dirstate_flag_mode_exec_perm;			flags &= ~dirstate_flag_mode_exec_perm;
	}			}
	#else			#else
	flags &= ~dirstate_flag_mode_exec_perm;			flags &= ~dirstate_flag_mode_exec_perm;
	#endif			#endif
				#ifdef S_ISLNK
				/* This is for platforms with support for symlinks */
	if (S_ISLNK(mode)) {			if (S_ISLNK(mode)) {
	flags \|= dirstate_flag_mode_is_symlink;			flags \|= dirstate_flag_mode_is_symlink;
	} else {			} else {
	flags &= ~dirstate_flag_mode_is_symlink;			flags &= ~dirstate_flag_mode_is_symlink;
	}			}
				#else
				flags &= ~dirstate_flag_mode_is_symlink;
				#endif
	return Py_BuildValue("iiii", flags, self->size, self->mtime_s,			return Py_BuildValue("iiii", flags, self->size, self->mtime_s,
	self->mtime_ns);			self->mtime_ns);
	};			};

	static PyObject dirstate_item_v1_state(dirstateItemObject self)			static PyObject dirstate_item_v1_state(dirstateItemObject self)
	{			{
	char state = dirstate_item_c_v1_state(self);			char state = dirstate_item_c_v1_state(self);
	return PyBytes_FromStringAndSize(&state, 1);			return PyBytes_FromStringAndSize(&state, 1);