( )⚙ D11712 parsers: don't ask about symlinks on platforms that don't support them

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D11712

parsers: don't ask about symlinks on platforms that don't support them
ClosedPublic

Authored by Alphare on Oct 20 2021, 1:07 PM.

Details

Reviewers
spectral
Group Reviewers
hg-reviewers
Commits
rHG126feb805247: parsers: don't ask about symlinks on platforms that don't support them
Summary

Otherwise the compiler gets quite sad.

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

Alphare created this revision.Oct 20 2021, 1:07 PM
spectral accepted this revision.Oct 20 2021, 2:13 PM
baymax updated this revision to Diff 30975.Oct 21 2021, 1:51 PM

✅ refresh by Heptapod after a successful CI run (🐙 💚)

Alphare added a commit: rHG126feb805247: parsers: don't ask about symlinks on platforms that don't support them.Oct 24 2021, 1:06 AM
This revision was not accepted when it landed; it landed in state Needs Review.
Closed by commit rHG126feb805247: parsers: don't ask about symlinks on platforms that don't support them (authored by Alphare). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/cext/parsers.c (5 lines)

Diff 30958

mercurial/cext/parsers.c

if ((mode & S_IXUSR) != 0) { if ((mode & S_IXUSR) != 0) {
flags |= dirstate_flag_mode_exec_perm; flags |= dirstate_flag_mode_exec_perm;
} else { } else {
flags &= ~dirstate_flag_mode_exec_perm; flags &= ~dirstate_flag_mode_exec_perm;
} }
#else #else
flags &= ~dirstate_flag_mode_exec_perm; flags &= ~dirstate_flag_mode_exec_perm;
#endif #endif
#ifdef S_ISLNK
/* This is for plaforms with support for symlinks */
if (S_ISLNK(mode)) { if (S_ISLNK(mode)) {
flags |= dirstate_flag_mode_is_symlink; flags |= dirstate_flag_mode_is_symlink;
} else { } else {
flags &= ~dirstate_flag_mode_is_symlink; flags &= ~dirstate_flag_mode_is_symlink;
} }
#else
flags &= ~dirstate_flag_mode_is_symlink;
#endif
return Py_BuildValue("iiii", flags, self->size, self->mtime_s, return Py_BuildValue("iiii", flags, self->size, self->mtime_s,
self->mtime_ns); self->mtime_ns);
}; };
static PyObject *dirstate_item_v1_state(dirstateItemObject *self) static PyObject *dirstate_item_v1_state(dirstateItemObject *self)
{ {
char state = dirstate_item_c_v1_state(self); char state = dirstate_item_c_v1_state(self);
return PyBytes_FromStringAndSize(&state, 1); return PyBytes_FromStringAndSize(&state, 1);