This is an archive of the discontinued Mercurial Phabricator instance.

rhg: lazily get filesystem metadata
Needs RevisionPublic

Authored by aalekseyev on Nov 2 2021, 8:06 AM.



rhg: use openat library for more efficient filesystem access

Diff Detail

rHG Mercurial
No Linters Available
No Unit Test Coverage

Event Timeline

aalekseyev created this revision.Nov 2 2021, 8:06 AM

@SimonSapin, this is a proof-of-concept patch I mentioned to you. It provides a large performance improvement in my benchmarks (in particular when running stat -mard), although I'm not entirely sure it's covered with tests.
It's not quite finished, in particular it doesn't handle the case when the filesystem doesn't return the file type. It also almost certainly doesn't work on Windows, but if we like the benchmarks then that can be worked out.

aalekseyev edited reviewers, added: SimonSapin; removed: hg-reviewers.Nov 2 2021, 8:22 AM
baymax requested changes to this revision.Feb 2 2022, 8:06 PM

There seems to have been no activities on this Diff for the past 3 Months.

By policy, we are automatically moving it out of the need-review state.

Please, move it back to need-review without hesitation if this diff should still be discussed.


This revision now requires changes to proceed.Feb 2 2022, 8:06 PM