Page MenuHomePhabricator

rhg: Propogate manifest parse errors instead of panicking
ClosedPublic

Authored by SimonSapin on Nov 23 2021, 2:10 PM.

Details

Summary

The Rust parser for the manifest file format is an iterator. Now every item
from that iterator is a Result, which makes error handling required
in multiple new places.

This makes better recovery on errors possible, compare to a run time panic.

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

SimonSapin created this revision.Nov 23 2021, 2:10 PM
Alphare accepted this revision.Nov 24 2021, 6:28 AM
This revision is now accepted and ready to land.Nov 24 2021, 6:28 AM
baymax updated this revision to Diff 31162.Nov 26 2021, 10:33 AM

✅ refresh by Heptapod after a successful CI run (🐙 💚)