Page MenuHomePhabricator

tests: make sure no ambiguities remains after the commit
ClosedPublic

Authored by marmoute on Nov 24 2021, 6:11 AM.

Details

Summary

This will help to stabilize part of the test that are not relevant for what is
actually tested.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

marmoute created this revision.Nov 24 2021, 6:11 AM
Alphare accepted this revision.Nov 24 2021, 7:57 AM
Alphare added a subscriber: Alphare.

This assumes a maximum granularity of one second even though some FS have more than that... but I don't think we should cripple the tests more than this. If it really is a problem, we'll find something else.

This revision is now accepted and ready to land.Nov 24 2021, 7:57 AM

This assumes a maximum granularity of one second even though some FS have more than that... but I don't think we should cripple the tests more than this. If it really is a problem, we'll find something else.

Yeah, if we end up running the test on strange FS, this will get flaky and we can build a small script that wait long enough.

marmoute retitled this revision from tests: make sure no ambiguity remains after the commit to tests: make sure no ambiguities remains after the commit.Nov 30 2021, 6:53 PM
marmoute edited the summary of this revision. (Show Details)