This is an archive of the discontinued Mercurial Phabricator instance.

Differential D11778

tests: make sure no ambiguities remains after the commit
ClosedPublic

Authored by marmoute on Nov 24 2021, 6:11 AM.

Details

Reviewers
Alphare
Group Reviewers
hg-reviewers
Commits
rHGa4a5d123fb03: tests: make sure no ambiguities remains after the commit
Summary

This will help to stabilize part of the test that are not relevant for what is
actually tested.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

marmoute created this revision.Nov 24 2021, 6:11 AM
Alphare accepted this revision.Nov 24 2021, 7:57 AM
Alphare added a subscriber: Alphare.

This assumes a maximum granularity of one second even though some FS have more than that... but I don't think we should cripple the tests more than this. If it really is a problem, we'll find something else.

This revision is now accepted and ready to land.Nov 24 2021, 7:57 AM
marmoute added a comment.Nov 29 2021, 1:39 PM
In D11778#180804, @Alphare wrote:

This assumes a maximum granularity of one second even though some FS have more than that... but I don't think we should cripple the tests more than this. If it really is a problem, we'll find something else.

Yeah, if we end up running the test on strange FS, this will get flaky and we can build a small script that wait long enough.

marmoute retitled this revision from tests: make sure no ambiguity remains after the commit to tests: make sure no ambiguities remains after the commit.Nov 30 2021, 6:53 PM
marmoute edited the summary of this revision. (Show Details)

Revision Contents
Changeset List

PathPackages
Mtests/test-dirstate-race2.t (6 lines)

Diff 31240

tests/test-dirstate-race2.t

outside of hg's control. outside of hg's control.
$ hg init repo $ hg init repo
$ cd repo $ cd repo
$ echo a > a $ echo a > a
$ hg commit -qAm _ $ hg commit -qAm _
$ echo aa > a $ echo aa > a
$ hg commit -m _ $ hg commit -m _
# this sleep is there to ensure current time has -at-least- one second away
# from the current time. It ensure the mtime is not ambiguous. If the test
# "sleep" longer this will be fine.
# It is not used to synchronise parallele operation so it is "fine" to use it.
$ sleep 1
$ hg status
$ hg debugdirstate --no-dates $ hg debugdirstate --no-dates
n 644 3 (set |unset) a (re) n 644 3 (set |unset) a (re)
$ cat >> $TESTTMP/dirstaterace.py << EOF $ cat >> $TESTTMP/dirstaterace.py << EOF
> from mercurial import ( > from mercurial import (
> extensions, > extensions,
> merge, > merge,