Page MenuHomePhabricator

dirstate: make it mandatory to provide parentfiledata in `set_clean`
ClosedPublic

Authored by marmoute on Nov 24 2021, 6:12 AM.

Details

Summary

Gathering the mode, size and mtime, independently from determining that the file
is clean is a race-machine. So we just make these information required arguments.

(note that the data is still gathered in a racy way in practice, but at least
the API is no longer encouraging it.)

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.